#57689 closed task (blessed) (fixed)
Bump default theme versions for WordPress 6.2
Reported by: | mukesh27 | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | Cc: |
Change History (23)
This ticket was mentioned in PR #4051 on WordPress/wordpress-develop by sanketio.
4 months ago
#1
- Keywords has-patch added; needs-patch removed
This ticket was mentioned in PR #4052 on WordPress/wordpress-develop by @robinwpdeveloper.
4 months ago
#3
Trac ticket: https://core.trac.wordpress.org/ticket/57689
@audrasjb commented on PR #4051:
4 months ago
#4
Thanks for the PR @sanketio. However, we need to add a changelog item for each version and to update enqueue versions as well.
See this changeset for 6.2 for reference.
#8
@
4 months ago
PR 4051 looks closer to ready than 4052, but it has new version dates for two JS files that have not been updated since before WordPress 6.0. During the last cycle, both Twenty Fifteen's functions.js
and Twenty Nineteen's touch-keyboard-navigation.js
were given a 20221101
version. Would leaving these two unchanged (as 20221101
) be better than using the (older) modified dates below?
The PR also needs to update version numbers for several CSS files that have been modified since November. Note: Twenty Nineteen sets the style-editor-customizer.css
version to 1.1
, yet [44650] made a substantial change for 1.3 and [51343] fixed a small typo in 2.1. For consistency, using the modified date may be preferable.
Modified dates:
Twenty Eleven (in functions.php
)
blocks.css | 20230122
|
Twenty Twelve
blocks.css | 20230213
|
editor-blocks.css | 20230213
|
Twenty Thirteen
blocks.css | 20230122
|
Twenty Fourteen
blocks.css | 20230206
|
editor-blocks.css | 20230206
|
Twenty Fifteen
blocks.css | 20230122
|
editor-blocks.css | 20230122
|
functions.js | 20220424 (maybe keep 20221101 )
|
Twenty Sixteen
blocks.css | 20230206
|
Twenty Nineteen
style-editor-customizer.css | 20210706 (it was updated for 2.1)
|
touch-keyboard-navigation.js | 20200129 (maybe keep 20221101 )
|
Other themes:
- Twenty Ten and Twenty Seventeen have not had CSS changes (other than
style.css
) since last November. - Twenty Twenty, Twenty Twenty-One and Twenty Twenty-Two dynamically update the version with
wp_get_theme()->get( 'Version' )
. - Twenty Twenty-Three does not enqueue any styles.
#9
@
4 months ago
I forgot to mention the changelog links for Twenty Twenty and more recent themes. Those URLs have /documentation/
instead of /support/
now (#57726).
Each of these also would need the last slash character before the hash (if not already there).
https://wordpress.org/documentation/article/twenty-twenty-one-changelog/#Version_1.0
#10
@
4 months ago
Noting here that it would be great to still land the (quite simple) fix for the Twenty Twenty bug reported in #57777 in time for this.
#11
@
4 months ago
@robinwpdeveloper Are you able to refresh your PR? Seems that sanketio
has not linked their GH profile to .org so can't ping here.
@robinwpdeveloper commented on PR #4052:
4 months ago
#12
Hi @desrosj
https://github.com/robinwpdeveloper/wordpress-develop/tree/57689 is now up to date with the latest trunk.
I think this is what you meant by refreshing PR.
This ticket was mentioned in Slack in #core by costdev. View the logs.
3 months ago
@audrasjb commented on PR #4052:
3 months ago
#14
Hi @robinwpdeveloper, more than just refreshing against trunk, the idea was to implement the feedback of comment:8 (see the Trac ticket)
#15
@
3 months ago
Changes made as per suggestion from @sabernhardt
Few skipped files (As I wasn't sure whether to change or not):
- Twenty Fifteen => functions.js
- Twenty Nineteen => style-editor-customizer.css, touch-keyboard-navigation.js
Let me know if anymore changes are needed.
This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.
3 months ago
@robinwpdeveloper commented on PR #4052:
3 months ago
#17
Thanks @audrasjb and @costdev.
Requested changes are made.
Trac ticket: https://core.trac.wordpress.org/ticket/57689