WordPress.org
Get WordPress

Make WordPress Core

Opened 3 months ago

Last modified 6 weeks ago

#57660 assigned defect (bug)

Tests_Formatting_MakeClickable should use data providors

Reported by: jorbin's profile jorbin Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

There are many tests in Tests_Formatting_MakeClickable that loop through arrays which means that if you have one failure, you stop running that group of tests. using a data provider would allow all the tssts to run and to catch issues quicker.

Change History (2)

#1 @hellofromTonya
6 weeks ago

  • Milestone changed from Awaiting Review to 6.3
  • Owner set to hellofromTonya
  • Status changed from new to assigned

Moving into 6.3 and currently working on a patch.

This ticket was mentioned in ​PR #4301 on ​WordPress/wordpress-develop by ​@hellofromTonya.
6 weeks ago #2

  • Keywords has-patch has-unit-tests added

Removes the foreach loops from the tests by moving the in-test data sets into data providers. But in doing so, the test assertions repeat throughout the URL tests (see the 1st commit in this PR).

To remove the redundancies, the 2nd commit combines the URL data sets into one data provider to test with one test method.

Trac ticket: https://core.trac.wordpress.org/ticket/57660

Note: See TracTickets for help on using tickets.