#459 closed task (blessed) (fixed)
Consider making moderation forum specific
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.6 | Priority: | high |
Severity: | normal | Version: | 0.7.2 |
Component: | API - Moderation | Keywords: | fixed-major |
Cc: | vpundir@…, jmdodd@…, stephen@…, jared@…, mercijavier@…, hamzahali@…, pericam@…, jjjay@… |
Description
Attachments (10)
Change History (95)
#3
@
16 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Then let's reopen.
The first step is to make sure we use the right caps everywhere and to make sure they're robust enough.
#6
@
14 years ago
- Milestone changed from 1.0 to 1.5
Leaving this one in the "maybe later" pile for now.
#8
@
12 years ago
- Milestone changed from Future Release to 2.1
- Version 0.7.2 deleted
Still valid today and often requested even for bbPress 2.0. Moving to 2.1 to research in next release.
#9
@
11 years ago
- Milestone changed from 2.1 to Future Release
Moving to future release. Should be done in 2.2.
#11
@
11 years ago
Looking forward to this in 2.2 - definitely a very common request and well be a very welcomed feature.
#13
follow-up:
↓ 14
@
11 years ago
Anybody with any ideas on the best setup for this? The old plugin linked from the original thread posted in the ticket description had the forum moderators setup under the Users menu.
Would this still be an acceptable place for the menu to be or should it be placed somewhere else?
Also, what would be the best place to store the access info? I'm guessing usermeta table with its own row? Would like to work on this to expand my skills but don't want to get too far into it only to have it shot down and require major changes and essentially waste time.
#14
in reply to:
↑ 13
@
11 years ago
Replying to JarretC:
Anybody with any ideas on the best setup for this? The old plugin linked from the original thread posted in the ticket description had the forum moderators setup under the Users menu.
Also, what would be the best place to store the access info? I'm guessing usermeta table with its own row? Would like to work on this to expand my skills but don't want to get too far into it only to have it shot down and require major changes and essentially waste time.
For a first pass, store an array of user_id's in each forum's postmeta. We can map the 'moderate' cap to the user as we need to after the fact.
This setting will really only be relevant on the forum page. I can see needing to query it from either direction, but we're stuck either way and building a UI inside the profile area to assign which forums to what users is beyond the scope of this ticket.
#15
follow-up:
↓ 17
@
11 years ago
also keep in mind the future bbpress->buddypress group forums and that bbpress may need to know about bp_group_admin_mods_...
maybe mimic the same functions/setup from buddypress but using roles/cap instead of db flags
#17
in reply to:
↑ 15
@
11 years ago
- Component changed from Administration to Moderation
- Milestone changed from 2.2 to Future Release
Replying to etivite:
also keep in mind the future bbpress->buddypress group forums and that bbpress may need to know about bp_group_admin_mods_...
maybe mimic the same functions/setup from buddypress but using roles/cap instead of db flags
Exactly. We'd map the 'moderate' cap to a user based on what forum they are viewing. Agree we'd want to play nicely with BuddyPress group moderators too.
That said, running out of time in 2.2 to do this, so moving to future release.
#21
@
11 years ago
I like this. The metabox idea is familiar, and an easy win. I think I'm okay with being able to add usernames that don't exist too. Suggesting names says "hey we found these matches" and letting the user add what they want says "hey, that's cool... whatevs."
#22
follow-up:
↓ 23
@
11 years ago
In the interest of possibly extending taxonomies to include participate and spectate for better ACL support, changed forum moderator taxonomy from 'forum-mod' to 'bbp-moderate'; helper functions in progress but I need to test them more thoroughly before dealing with assigning/modifying capabilities based on forum.
#23
in reply to:
↑ 22
@
11 years ago
Replying to jmdodd:
In the interest of possibly extending taxonomies to include participate and spectate for better ACL support, changed forum moderator taxonomy from 'forum-mod' to 'bbp-moderate'; helper functions in progress but I need to test them more thoroughly before dealing with assigning/modifying capabilities based on forum.
This makes sense to me. Also opens the door back up for Bozo support, too.
#24
follow-up:
↓ 59
@
11 years ago
Helper functions in 459.3.diff have been tested and are working fine with test users and assigning them to moderate forums. Getting back expected results re: forum moderators and moderator's forums.
Rough numbers for the current codebase (r4532):
~200 instances of 'current_user_can', including the following functions that look like they could be consolidated:
- bbp_current_user_can_publish_forums(), bbp_current_user_can_access_create_forum_form(),
- bbp_current_user_can_publish_topics(), bbp_current_user_can_access_create_topic_form(),
- bbp_current_user_can_publish_replies(), bbp_current_user_can_access_create_reply_form().
12 instances of 'bbp_user_can_view_forum'.
20 instances of 'user_can'.
Possibilities:
- Rolling our own bbp_user_can() (bbp_current_user_can()?) and trying to figure out what we're asking permission for via globals. I'd rather not get too far divorced from WordPress on capability handling so this is not really my favorite solution.
- A thorough audit to make sure that the relevant forum/topic/reply ids are being passed to current_user_can(), and that the right caps are being checked.
- Filtering on user_has_cap might also work, but I think passing explicit forum/topic/reply ids is preferable to relying on global values.
#25
@
10 years ago
- Milestone changed from 2.3 to 2.4
Looking like a bit of a rabbit hole, so let's move this off to 2.4. This gives us time to iterate on these other architectural issues until then.
#28
@
10 years ago
- Milestone changed from 2.4 to 2.5
No movement in a while. No time for 2.4. Moving to 2.5.
#29
@
10 years ago
- Milestone changed from 2.5 to 2.6
2.5 is going to focus on performance improvements. Moving to 2.6.
#32
follow-up:
↓ 34
@
9 years ago
Per John James Jacoby's suggestion, I've uploaded the draft version of a plugin I wrote. It optionally works with the User Groups plugin by Katz Web Services if installed. It needs some TLC by experts in actions + filters, I18N, etc.
#33
@
9 years ago
In 459.4.diff:
Refresh of 459.3.diff to apply cleanly against /trunk
#34
in reply to:
↑ 32
@
9 years ago
Replying to smithwib:
Per John James Jacoby's suggestion, I've uploaded the draft version of a plugin I wrote. It optionally works with the User Groups plugin by Katz Web Services if installed. It needs some TLC by experts in actions + filters, I18N, etc.
@smithwib Thanks for the upload, will take a look at your plugin soon.
#35
follow-up:
↓ 36
@
9 years ago
Really liking the progress on patches here. There are a few things I'd like to tweak, but overall think this is the way to go. With a patch attached, I'm wondering if we can move this to 2.6, and move bbPress comments to 2.7.
#36
in reply to:
↑ 35
@
9 years ago
Replying to johnjamesjacoby:
I'm wondering if we can move this to 2.6, and move bbPress comments to 2.7.
Either/or, I've been looking at this with the goal of 'bozo' functionality as bbPress v2.x starts appearing (and/or thinking of appearing) on more wordpress.org sites.
Also of note is 'bbPress Per Forum Moderation' is part of @dragooon's (Shitiz Garg) GSoC proposal.
#37
@
9 years ago
- Keywords needs-testing added
- Milestone changed from 2.7 to 2.6
- Type changed from enhancement to task
#38
@
9 years ago
The only problem I see with this patch is get_objects_in_term()
is not cached, meaning we'll need to add our own setting/busting for this on CRUD actions.
#39
@
9 years ago
wp_get_object_terms()
usage needs to be checked to make sure caching is sufficient also.
#41
@
9 years ago
Do we want to list the forums moderators anywhere?
Below screenshot/hack in the forum template notice and/or after the forum description.
Looking at that above if it was to be in the template notice something more along the lines of:
This forum is moderated by User123, contains 2 topics and 3 replies, and was last updated by admin 2 weeks ago.
I think I may have just answered my own question as to a decision or option, if a forum as 10 moderators this will get ugly quite quickly...
#42
follow-up:
↓ 43
@
9 years ago
Testing 459.diff 'Forum Moderator' vs 'Moderator' capability checks:
- 'Moderator' can 'edit others topics' - 'Forum Moderators' cannot
- 'Moderator' can 'edit topic tags' - 'Forum Moderators' cannot
- 'Moderator' and 'Forum Moderators' can merge, split, close, stick and spam topics/replies
#43
in reply to:
↑ 42
;
follow-up:
↓ 44
@
9 years ago
Replying to netweb:
Testing 459.diff 'Forum Moderator' vs 'Moderator' capability checks:
- 'Moderator' can 'edit others topics' - 'Forum Moderators' cannot
- 'Moderator' can 'edit topic tags' - 'Forum Moderators' cannot
- 'Moderator' and 'Forum Moderators' can merge, split, close, stick and spam topics/replies
This seems fine to me, and the desired result IMO.
#45
@
9 years ago
Whilst digging around with topic and reply moderation I found a few issues with topics and replies whose post status is pending
.
You cannot view any topics or replies with status pending
on the front end, forum moderator, moderator or keymaster included. This includes using the view=all
query string.
To view topics and replies and approve them you must be a keymaster and approve them from the backend.
#46
@
9 years ago
- Cc hamzahali@… added
I did testing for this one, seems working fine, only the add moderator option in forums menu (admin area) seems to be of no use, Till when can we expect this to be included in the core.
#49
follow-up:
↓ 50
@
9 years ago
The last file, includes/users/functions.php
I couldn't find anywhere to place the code!! Then I just have it placed on the bottom, and I fail!
What version you guys test it for?
#50
in reply to:
↑ 49
@
9 years ago
Replying to dreamwork:
The last file, includes/users/functions.php
I couldn't find anywhere to place the code!! Then I just have it placed on the bottom, and I fail!
What version you guys test it for?
You need to apply the patch against the bbPress development source code, see the WordPress handbook on working with patches here (and related references in the handbook). If you have any other questions please post on the support forums https://bbpress.org and I'll answer them there as discussing them here in this ticket is not the place for these discussions.
#51
@
9 years ago
In 459.5.diff a refresh of 459.diff to apply cleanly against /trunk
#52
@
9 years ago
I hope this ticket never closes. I use the email notifications to remind me which decade I'm in.
This ticket was mentioned in Slack in #meta by jjj. View the logs.
9 years ago
#56
@
8 years ago
- Milestone changed from 3.0 to 2.6
Let's get this into 2.6 and stop being a cheat sheet for @sambauers ;)
p.s. New Year, Same Decade
This ticket was mentioned in Slack in #meta-i18n by netweb. View the logs.
8 years ago
#59
in reply to:
↑ 24
@
8 years ago
Have refreshed the existing patches in 459.6.diff: with updated docs, formatting a few minor fixes.
I'm currently writing a bunch of unit tests outlined in comment:24
Still yet to look at get_objects_in_term()
and caching mentioned in comment:38
Also needing to look at wp_get_object_terms()
caching mentioned in in comment:39:
Merging this should be good to go, merging sooner rather than later so another refresh isn't needed, iterate further once committed.
#68
@
8 years ago
- Keywords needs-testing removed
- Resolution set to fixed
- Status changed from reopened to closed
Let's call this "fixed" and open new tickets for new issues & enhancements, likely in 2.7.
Sam, you may want to find a new ticket to subscribe to. <3
This ticket was mentioned in Slack in #bbpress by netweb. View the logs.
8 years ago
This ticket was mentioned in Slack in #bbpress by netweb. View the logs.
8 years ago
#71
@
8 years ago
- Cc jjjay@… added
Sorry, I'm not quite sure if I should add this here or open a new one or what. Anyway, here's a slightly different way of doing it with some more admin bits.
#74
@
7 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Zombie ticket.
Reopen so per-forum moderators can be refactored to use metadata vs. mock-taxonomy.
#79
@
6 years ago
- Keywords fixed-major added
- Resolution set to fixed
- Status changed from new to closed
- Version set to 0.7.2
👾 👾 👾 👾 👾 👾
👾 👾 👾 👾 👾 👾
👾 💥 👾 👾 👾 👾
🚀
This could be considered closed as so10 has created a plugin for this as well.
http://bbpress.org/forums/topic/403?replies=4
Trent