Only pass parentLayout to block edit if not empty #46390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
Size Change: +14 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
noisysocks
reviewed
Dec 8, 2022
| @@ -152,7 +152,9 @@ function BlockListBlock( { | |||
| isSelectionEnabled={ isSelectionEnabled } | |||
| toggleSelection={ toggleSelection } | |||
| __unstableLayoutClassNames={ layoutClassNames } | |||
| __unstableParentLayout={ parentLayout } | |||
| __unstableParentLayout={ | |||
| Object.keys( parentLayout ).length ? parentLayout : undefined | |||
There was a problem hiding this comment.
Is it possible for parentLayout to be null or undefined? If so Object.keys() will throw an exception here.
There was a problem hiding this comment.
I don't think so, but perhaps it's best to explicitly make it default to an empty object to be on the safe side.
noisysocks
approved these changes
Dec 8, 2022
|
Some checks are failing, I'll attempt a rebase from |
fullofcaffeine
force-pushed
the
fix/parent-layout-prop
branch
from
f2391e1
to
ab9ea4e
Compare
|
Thanks for the fix @tellthemachines! |
fullofcaffeine
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Only pass parentLayout to block edit if not empty * Make sure object.keys check doesn't error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Follow-up to #45364.
How?
Adds logic so that
allowSizingOnChildrendoesn't get passed to the Edit function of every single block, even when the parent block isn't setting it explicitly. If the parent block has no layout configured,__unstableParentLayoutshould be undefined.Testing Instructions
Testing Instructions for Keyboard
With a child of a Row block selected, press Tab to go into the sidebar, Tab again to go the "Block" area, and then continue tabbing until reaching the "Dimensions options" button. Press Enter to open, Tab until reaching "Width" and press Enter to select. Press Esc to close the dropdown and then press Tab again to focus the Width control. Once focused, toggle between the options with Arrow keys. If selecting "Fixed", Tab again to reach the input and fill it in with a fixed width value.
Screenshots or screencast