Changeset 54780

Timestamp:

11/09/2022 06:33:01 PM (18 months ago)

Author:

desrosj

Message:

Query: Bypass caching for filtered SELECTs.

Bypass caching within WP_Query when the SELECT clause has been modified via a filter. This prevents both cache key collisions and the returning of incomplete or unexpected results when the SELECT clause has been modified by an extender.

Props pypwalters, claytoncollie, johnwatkins0, TimothyBlynJacobs, costdev, spacedmonkey, peterwilsoncc.
Merges [54768] to the 6.1 branch.
Fixes #57012.

Location:

branches/6.1

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-query.php (modified) (1 diff)
• tests/phpunit/tests/query/fieldsClause.php (copied) (copied from trunk/tests/phpunit/tests/query/fieldsClause.php)

branches/6.1/src/wp-includes/class-wp-query.php

@@ -3104 +3104 @@
          * search, that to ensure against a collision with another
          * function.
+         *
+         * If `$fields` has been modified by the `posts_fields`,
+         * `posts_fields_request`, `post_clauses` or `posts_clauses_request`
+         * filters, then caching is disabled to prevent caching collisions.
          */
         $id_query_is_cacheable = ! str_contains( strtoupper( $orderby ), ' RAND(' );
+
+        $cachable_field_values = array(
+            "{$wpdb->posts}.*",
+            "{$wpdb->posts}.ID, {$wpdb->posts}.post_parent",
+            "{$wpdb->posts}.ID",
+        );
+
+        if ( ! in_array( $fields, $cachable_field_values, true ) ) {
+            $id_query_is_cacheable = false;
+        }
+
         if ( $q['cache_results'] && $id_query_is_cacheable ) {
             $new_request = str_replace( $fields, "{$wpdb->posts}.*", $this->request );