DB/DirectDatabaseQuery: implement PHPCSUtils and support modern PHP #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is a remnant of the old-style custom ignore comment mechanism which was removed in 2063.
... to cover the one uncovered line.
👉 This change will be easier to review while ignoring whitespace changes.
…ator Prevent false negatives in case someone would use the PHP 8.0 nullsafe object operator on the `$wpdb` variable. Also makes the token walking more stable by preventing an unrelated object operator from being recognized as if it were an operator operating on the `$wpdb` object (false positive). Includes tests.
Don't allow the sniff to get confused by comments. Related to 763 Includes tests.
Prevent false positives from walking too far when a database query statement is ended by a PHP close tag. Includes unit tests.
Prevent unsolvable false positives for `TRUNCATE` queries. Those cannot be cached and need a direct DB query. (second opinion appreciated!) Includes unit tests. Fixes 1947
19 tasks
|
Note: this sniff is not that stable as the token walking is not very strict. Realistically, it could do with a complete rewrite, but that is outside the scope of what I was trying to achieve now. Also just saw #864, which makes me question the |
dingo-d
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB/DirectDatabaseQuery: remove redundant code
This code is a remnant of the old-style custom ignore comment mechanism which was removed in #2063.
DB/DirectDatabaseQuery: add missing test case
... to cover the one uncovered line.
DB/DirectDatabaseQuery: implement PHPCSUtils
👉 This change will be easier to review while ignoring whitespace changes.
DB/DirectDatabaseQuery: add support for PHP 8.0+ nullsafe object operator
Prevent false negatives in case someone would use the PHP 8.0 nullsafe object operator on the
$wpdbvariable.Also makes the token walking more stable by preventing an unrelated object operator from being recognized as if it were an operator operating on the
$wpdbobject (false positive).Includes tests.
DB/DirectDatabaseQuery: bug fix - code style independent token walking
Don't allow the sniff to get confused by comments.
Related to #763
Includes tests.
DB/DirectDatabaseQuery: bug fix - finding end of statement
Prevent false positives from walking too far when a database query statement is ended by a PHP close tag.
Includes unit tests.
DB/DirectDatabaseQuery: bug fix - ignore TRUNCATE queries
Prevent unsolvable false positives for
TRUNCATEqueries. Those cannot be cached and need a direct DB query. (second opinion appreciated!)Includes unit tests.
Fixes #1947