Changeset 54250

Timestamp:

09/20/2022 01:10:24 PM (8 months ago)

Author:

SergeyBiryukov

Message:

Bootstrap/Load: Send HTTP headers after querying posts in WP::main().

By running WP::send_headers() after posts have been queried, we can ensure that conditional tags like is_front_page(), is_home(), etc. work as expected.

This provides better context and more flexibility when adjusting HTTP headers via the wp_headers filter or send_headers action.

Previously, the earliest action where conditional tags worked correctly was wp.

Includes moving the X-Pingback header, previously sent in WP::handle_404()​ after posts have been queried, to a more appropriate place in WP::send_headers().

Follow-up to [2627], [34442].

Props jonoaldersonwp, joostdevalk, peterwilsoncc, adamsilverstein, SergeyBiryukov.
Fixes #56068.

Location:

trunk

Files:

• src/wp-includes/class-wp.php (modified) (5 diffs)
• tests/phpunit/tests/wp/sendHeaders.php (added)

trunk/src/wp-includes/class-wp.php

@@ -409 +409 @@
      *
      * @since 2.0.0
-     * @since 4.4.0 `X-Pingback` header is added conditionally after posts have been queried in handle_404().
+     * @since 4.4.0 `X-Pingback` header is added conditionally for single posts that allow pings.
+     * @since 6.1.0 Runs after posts have been queried.
      */
     public function send_headers() {
@@ -505 +506 @@
         }
 
+        if ( is_singular() ) {
+            $post = isset( $wp_query->post ) ? $wp_query->post : null;
+
+            // Only set X-Pingback for single posts that allow pings.
+            if ( $post && pings_open( $post ) ) {
+                $headers['X-Pingback'] = get_bloginfo( 'pingback_url', 'display' );
+            }
+        }
+
         /**
          * Filters the HTTP headers before they're sent to the browser.
@@ -702 +712 @@
             if ( is_singular() ) {
                 $post = isset( $wp_query->post ) ? $wp_query->post : null;
-
-                // Only set X-Pingback for single posts that allow pings.
-                if ( $post && pings_open( $post ) && ! headers_sent() ) {
-                    header( 'X-Pingback: ' . get_bloginfo( 'pingback_url', 'display' ) );
-                }
+                $next = '<!--nextpage-->';
 
                 // Check for paged content that exceeds the max number of pages.
-                $next = '<!--nextpage-->';
                 if ( $post && ! empty( $this->query_vars['page'] ) ) {
                     // Check if content is actually intended to be paged.
@@ -771 +776 @@
         $parsed = $this->parse_request( $query_args );
 
-        $this->send_headers();
-
         if ( $parsed ) {
             $this->query_posts();
@@ -779 +782 @@
         }
 
+        $this->send_headers();
+
         /**
          * Fires once the WordPress environment has been set up.