Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates: packages, PHPCs, etc #428

Merged
merged 2 commits into from Nov 13, 2021
Merged

Updates: packages, PHPCs, etc #428

merged 2 commits into from Nov 13, 2021

Conversation

@renatonascalves
Copy link
Member

@renatonascalves renatonascalves commented Nov 3, 2021

  • Upgrading the wp-env package
  • yoast/phpunit-polyfills introduced
  • wp-phpunit/wp-phpunit upgraded to 5.8
  • Updating package.json to check current node version before moving forward.
  • Fixing the last PHPCS issue
  • Updating readme.md
  • Updating WordPress version (related https://buddypress.trac.wordpress.org/ticket/8571)
@renatonascalves renatonascalves self-assigned this Nov 3, 2021
@renatonascalves renatonascalves requested a review from imath Nov 3, 2021
imath
imath approved these changes Nov 8, 2021
Copy link
Member

@imath imath left a comment

Thanks for your work on this. It looks good. I'd probably test upgrading the wp-phpunit package to 5.8 running composer require --dev "wp-phpunit/wp-phpunit: ^5.8" 😉

Loading

README.md Show resolved Hide resolved
Loading
README.md Show resolved Hide resolved
Loading
@renatonascalves
Copy link
Member Author

@renatonascalves renatonascalves commented Nov 13, 2021

wp-phpunit/wp-phpunit was upgraded as suggested to 5.8 and also yoast/phpunit-polyfills was introduced so that the unit tests are run correctly.

Loading

@renatonascalves renatonascalves merged commit aed04b7 into master Nov 13, 2021
5 checks passed
Loading
@renatonascalves renatonascalves deleted the feature/upgrade branch Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants