Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #268

Merged
merged 6 commits into from
Jul 19, 2021
Merged

Fix tests #268

merged 6 commits into from
Jul 19, 2021

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Jul 14, 2021

Fixes PHPUnit tests so that they can be run locally without issues

Also fixes PotGenerator to check for ParsedComment instances as these can now be returned since v4.8.5 (php-gettext/Gettext#271)

See https://github.com/wp-cli/i18n-command/runs/3065527614#step:12:627 for how tests are currently failing

@swissspidy swissspidy requested a review from a team as a code owner July 14, 2021 10:33
@swissspidy swissspidy merged commit 66dd90b into master Jul 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/tests branch July 19, 2021 13:58
@schlessera schlessera added this to the 2.2.9 milestone Jul 19, 2021
schlessera pushed a commit that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants