Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing --network parameter for plugin is-active #222

Merged
merged 2 commits into from Apr 8, 2020
Merged

Missing --network parameter for plugin is-active #222

merged 2 commits into from Apr 8, 2020

Conversation

jespervnielsen
Copy link
Contributor

The code checks for the argument "network" but its not possible to add it, since the cli fails because its not declered as a valid param.

This fix add's it as a argument.

The code checks for the argument "network" but its possible to add it, since the cli fails because its not declered as a valid param.
@jespervnielsen jespervnielsen requested a review from a team as a code owner Apr 3, 2020
Copy link
Member

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

I just have a tiny nitpick, and then it's good to merge!

src/Plugin_Command.php Outdated Show resolved Hide resolved
add missing dot

Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
@schlessera schlessera changed the title Missing --network param for is-active Missing --network parameter for plugin is-active Apr 8, 2020
@schlessera schlessera added this to the 2.0.9 milestone Apr 8, 2020
@schlessera schlessera merged commit 768592a into wp-cli:master Apr 8, 2020
@jespervnielsen jespervnielsen deleted the patch-1 branch Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants