PHP 8.2 | Fix deprecated embedded variables in text strings

[jrfnl]

What?

PHP 8.2 will deprecate two of the four currently supported syntaxes for embedding variables in double quoted text string/heredocs.

This library contains six uses of embedded variables using braces after the dollar sign ("${foo}"), which is one of the deprecated forms.

This commit fixes all six.

Refs:

• https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation

Why?

Because code should be cross-version compatible with all supported PHP versions, including the upcoming PHP 8.2.

[gziolo]

This library contains six uses of embedded variables using braces after the dollar sign ("${foo}"), which is one of the deprecated forms.

It’s a JavaScript syntax for variables in strings. 😃 Thank you for spotting and correcting it 👍

[anton-vlasenko]

LGTM!
Nice job.

[jrfnl]

Does this need a port to WP Core ? Will this be handled automatically or should I open a PR to Core for this too ?

[anton-vlasenko]

I wonder if this particular PR needs porting, as Core version of the WP_Theme_JSON class uses sprintf() for concatenation and probably(?) doesn't need this fix.
In general, a Backport to WP Beta/RC or a Backport to WP minor release label should be added to PRs that need backporting.

Will this be handled automatically or should I open a PR to Core for this too ?

As far as I know, this is handled by the release managers.
Here is the tracking issue for all Gutenberg PRs that need backporting:
#43440

[jrfnl]

@anton-vlasenko I have added the labels, let's see what happens...

[michalczaplinski]

Hey 👋 I've removed the labels as this PR will not need to be ported to Core. The equivalent function in Core is already using the sprintf() syntax.

I wonder if in fact the GB should have the same syntax here as the Core one 🤔 .

[jrfnl]

Thanks @michalczaplinski for investigating.

I wonder if in fact the GB should have the same syntax here as the Core one

I imagine that would greatly improve the code readability as it reduces the length of that really long long line and makes it clear which are the variable parts.