THEME: Spartan - 1.2.17

[tskk]

Spartan - 1.2.17

Responsive wordpress magazine theme with 3 home page layouts, 2 page layouts including a full width page template, featured posts slider, social icons, twitter updates, threaded comments, custom background, custom colors and widget support.

Theme URL - ​http://www.themealley.com/Spartan/
Author URL - ​http://www.themealley.com/

SVN - ​http://themes.svn.wordpress.org/spartan/1.2.17
ZIP - ​http://wordpress.org/extend/themes/download/spartan.1.2.17.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/spartan/1.2.16&new_path=/spartan/1.2.17

All previous tickets for this theme: ​http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-spartan&order=id

Hi tskk,

I was able to fix the issue by assigning a specific default value to "std" in options.php, line 76:

"std" => "silver",

Can you try that and see if it works for you? Also, are you developing on a local server or on a remote server? Do you have WP_DEBUG set to true? If it's a remote server that's not reporting all the notices and error messages, you might want to try a local server, using WAMP (if you're not already doing so).

The widget image fix looks good. I would apply that same fix for images inside the main content area as well (either add ".entry img" to the ".widget img" rule, or you can just add a "height: auto" to "p img"), because they start to look distorted as the screen size grows smaller. This isn't a blocker for approval though, but it's worth fixing.

Other things to fix for the next upgrade

These aren't blockers for this version but are recommended for the next upgrade:

• It would be great if you can clean up the spacing in the theme files. Many files, such as functions.php, have large spaces between lines. For example: lines 87-99 are blank in functions.php. There shouldn't be more than 1 empty line between code sections.
• There is no need for a closing PHP tag in functions.php. This can help avoid white screen/"headers already sent" errors
• There are several places in functions.php that are using spaces at the beginnings of lines instead of tabs. For example, lines 191-228. There may be other areas in the theme as well.

In the next version of the theme, it would be great go through the theme files and clean up the PHP so that it is in line with the latest WordPress.org PHP standards: ​http://make.wordpress.org/core/handbook/coding-standards/php/

Will add fix for images and clean up the code.

I am developing on remote server. Had the hosting support set the error reporting to e_all as Stephen from the other ticket mentioned but still am not getting the error. So i should try WAMP

Kirk reviewed another theme of mine (Destro) and looks like he did not get the error either.

Thanks a ton for the patience, appreciate it :)
Srikanth

added "std" => "silver", and height:auto;
​http://themes.trac.wordpress.org/ticket/12271

Will clean up code in next few versions.

Thanks! This ticket can be closed, since there is a newer version that has been approved.