THEME: BoldR Lite - 1.0.1

[Iceable]

BoldR Lite - 1.0.1

A bold, magazine style responsive WordPress Theme.

Theme URL - ​http://demo.iceable.com/boldr-lite/
Author URL - ​http://www.iceable.com

SVN - ​http://themes.svn.wordpress.org/boldr-lite/1.0.1
ZIP - ​http://wordpress.org/extend/themes/download/boldr-lite.1.0.1.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/boldr-lite/1.0&new_path=/boldr-lite/1.0.1

All previous tickets for this theme: ​http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-boldr-lite&order=id

All Applicable Files

• Themes are required to escape user-entered data from the theme options page before printing that data onto the screen. This is an important security measure. Echoed/displayed theme options data in header.php and footer.php (and possibly other places, check all of the theme files) needs escaping. For help with this, please see: ​​​http://developer.wordpress.com/themes/escaping/ and ​​​http://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data#Escaping:_Securing_Output. Also, feel free to ask if you have any questions.

header.php

• There are references to icefit_get_option('headings_font'), but I don't see this option on the Theme Options page. If it's not in use, it should be removed. Also, the Google fonts (line 51) should be enqueued in a function in functions.php, and not hard-linked in the template file. Please see how the Open Sans font is enqueued in Twenty Twelve for an example (​​http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwelve/functions.php#L85 and ​​http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwelve/functions.php#L130).

Licensing

• For best compatibility, it's strongly recommended to use the GPL v2.0 or later license. ​http://www.gnu.org/licenses/gpl-2.0.html

functions.php

• Line 65: it's not necessary to enqueue jQuery separately since you are already passing jQuery as a dependency when you enqueue each script.
• All theme-specific functions must be prefixed with the theme name. For example, "add_menu_parent_class()" needs a prefix. I see that you have some functions that are prefixed with "icefit". It would be better to use "boldr", the actual theme name. This would help to avoid confusion and make the code easier to understand. However, using "icefit" is also fine. Just pick one and use it consistently throughout all theme files.

This is not a full review. Please fix the issues noted above, and submit a new version so that the review can continue. If you have questions, don't hesitate to ask.

Suggested resolution: Closed, Not-Approved.

Thank you for your time and feedback. Updated revision is at: ​#12318

• Fixed: escape user-entered data
• 'headings_font' is indeed unused and has been removed, and google fonts are now properly enqueued
• Licensing: you are totally right (especially with some bundled ressources that are licensed under GPLv2), I switched to v2
• Removed unnecessary jQuery enqueue
• Prefixed all theme functions appropriately. I know it is recommended to use theme-slug, but I sticked to "icefit" which is my framework's slug for all functions and textdomain. This makes it easier to maintain and update these functions that are shared by all my themes.
• + a few more fixes and updates

Thanks !