Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort externalized dependencies report. #37377

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

tomalec
Copy link
Contributor

@tomalec tomalec commented Dec 14, 2021

Description

Sort externalized dependencies report.
So we can produce a stable, stringified representation, more git merge friendly.

Previously, the list of externalized dependencies was not sorted, and its order relied on the order of processed imports, which may change dynamically during the plugin's development. This somewhat "natural" order does not provide any significant information or value to the report. Therefore to reduce the number of merge conflicts, git diffs that takes the developer's attention, and time, we shall sort it for a more stable result.

How has this been tested?

cd packages/dependency-extraction-webpack-plugin
npm link
cd path/to/google-listings-and-ads
npm link dependency-extraction-webpack-plugin
npm run build

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • [n/a] I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • [n/a] I've included developer documentation if appropriate.
  • [n/a] I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

 So we can produce a stable, stringified representation, more git merge friendly.
@gziolo gziolo marked this pull request as ready for review December 14, 2021 15:50
@gziolo gziolo self-requested a review as a code owner December 14, 2021 15:50
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gziolo gziolo added [Package] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Type] Code Quality Issues or PRs that relate to code quality labels Dec 14, 2021
@gziolo gziolo merged commit 7225e63 into WordPress:trunk Dec 14, 2021
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 14, 2021
@tomalec
Copy link
Contributor Author

tomalec commented Dec 14, 2021

Thanks, that was fast 🚀 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants