Revert "runtime: allow over-aligned types in the runtime" #58499
+16
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
mikeash
approved these changes
on Apr 28, 2022
compnerd
approved these changes
on Apr 29, 2022
Seems reasonable to me however, the commit message could use a bit of tweaking - it was a fix for non-alignment aware operator new (on <C++17) for non-Darwin 32-bit platforms, not specifically Windows.
FWIW the commit message is just:
But I'll amend the PR description to clarify. |
al45tair
approved these changes
on May 3, 2022
|
Just need to fix up Heap.h, then I can merge. |
grynspan
force-pushed
the
jgrynspan/58498-remove-aligned_alloc-template
branch
2 times, most recently
from
3ecb165
to
05aee0b
Compare
This reverts commit b694ce4.
grynspan
force-pushed
the
jgrynspan/58498-remove-aligned_alloc-template
branch
from
05aee0b
to
b749dd3
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
swift::aligned_alloc(and friends) was added as a workaround for 32-bit platforms'operator newunder-aligning allocations, but this was later corrected more cleanly by including<new>for placement new and by usingswift_cxx_newObject()to rely onswift_slowAlloc()for allocations instead ofoperator new. The commit that addedswift::aligned_alloccan be removed now.This change reverts commit b694ce4.
Resolves #58498.