Opened 7 weeks ago
Closed 20 minutes ago
#8571 closed task (fixed)
Raise WordPress required version to 5.4
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 10.0.0 | Priority: | normal |
Severity: | normal | Version: | 7.0.0 |
Component: | Core | Keywords: | has-patch |
Cc: |
Description
It's been a while we haven't updated the WordPress required version. That's mainly because WordPress 5.9 is still used by more than 5% of users see: https://wordpress.org/about/stats/
But, WP 4.9.8 was released 3 years ago. Next WordPress version will be 5.9 and we'd support back to 10 WP versions.
I suggest to raise this required version to 5.4 as 5.0 to 5.3 are below 5%.
Attachments (4)
Change History (19)
This ticket was mentioned in Slack in #buddypress by imath. View the logs.
7 weeks ago
This ticket was mentioned in Slack in #buddypress by imath. View the logs.
5 weeks ago
#4
@
3 weeks ago
Hi @imath,
Your patch looks good to me. I just want to mention, do we still need to check version before register block components?
https://github.com/buddypress/buddypress/blob/master/src/bp-core/bp-core-blocks.php#L34
https://github.com/buddypress/buddypress/blob/master/src/bp-core/bp-core-blocks.php#L21
#5
@
3 weeks ago
- Keywords needs-patch added; has-patch removed
Thanks for your feedback @oztaser: good catch, you're totally right. I'll update the patch asap.
#6
@
7 days ago
- Keywords has-patch added; dev-feedback needs-patch removed
8571.2.patch improves the first patch, removing no more needed WP version 5.0.0 checks. I still need to work on a last WP version 5.3.0 check as in 9.0.0 I've introduced a new rest component to be back compatible with 5.3.0 and lower versions. I'll do some tests about it from the BP Blocks plugin.
#8
@
27 hours ago
PHPUnit tests about WP 5.4 failed. See https://github.com/buddypress/buddypress/runs/4131848278.
I believe it is due to the fact we are using a too high version of the wp-phpunit/wp-phpunit
composer package when running WP 5.4 tests.
#9
@
27 hours ago
- Keywords needs-patch added; has-patch removed
In 8571.3.patch I'm adding a new step "Adjust wp-phpunit version" to the GitHub action to use version 5.4 of wp-phpunit when the tested WordPress version is 5.4.
Let's see if this is fixing the PHPUnit issue.
#13
@
16 hours ago
I've just tested the last step of the process: removing the Compatibility ServerSideRender BP Component from the BP Blocks plugin. Everything looks fine from there, I'll add a patch here shortly.
@
28 minutes ago
#14
@
26 minutes ago
- Keywords has-patch added; needs-patch removed
8571.4.patch includes the needed changes to remove the Compatibility ServerSideRender BP Component and directly use WordPress one.
#15
@
20 minutes ago
- Owner set to imath
- Resolution set to fixed
- Status changed from new to closed
In 13144:
8571.patch is raising WP required version to 5.4 and deprecates functions that are no more needed now we support up to 4.9. For instance, we don't need the
bp.apiRequest
function that were used as awp.apiRequest
polyfill.It also adds the WP 5.4 to the WP version our PHPunit GitHub action is testing.