Size Change: +959 B (0%)

Total Size: 1.07 MB

_{compressed-size-action}

Hey, I've given this a run and this is what I see:

core + theme palette

👌 I've tried core and theme palette for some themes and it's working well for these ones:

• Empty theme (a theme with theme.json and no color palette)
• TT1-blocks (a theme with theme.json and palette)
• TwentyTwentyOne (theme with theme supports, and color palette, plus link support via theme supports)
• TwentyTwenty (a theme with theme supports and color palette)

⚠️ There's this other theme, Storefront, a theme with theme supports and no color palette, for which the theme palette is still shown (although it's the same as core's).

This stems from the fact that __experimentalFeatures.color.palette.theme does have the colors as well. This sounds like something to investigate separately. I can look into that.

user styles

❓ For user palette, this is what I see when the user changes the color value of the "black" color to set it to red-ish (silly thing, I know, but it works for stress testing :) ):

👌 Then I reset the changes to start over and the user palette is no longer shown.

❓ The other test I've done is what happens when the user adds a new color (reset the changes above and start fresh):

❓ Finally, I've switched themes and verified that the user colors are cleared because they are tied to the theme.

This raised a couple of questions around how do we expect this to work for users:

• What do we expect to find in the user color palette? I'd presume only the user modifications (colors whose value was changed or new colors added by the user).
• What do we expect to happen to user color palettes when switching themes?

blocks that don't use block supports

Without having done a deep dive into the code yet, I've noticed this updates a few components so a number of blocks will have the new design:

• The ones that use the hooks bound to the color block support mechanism.
• Other blocks, such as cover, don't use the color support mechanism but they do use the PanelColorGradientSettings component from the block-editor package, which was also updated.

I've noticed that there are some other blocks, such as navigation, that don't use the color support mechanism and use the PanelColorSettings color component from the block-editor package (which wasn't updated, apparently). These won't have the new design. I wonder what's the way forward for these blocks. Sorry if I'm asking questions that have been probably already discussed in the components PRs, but I'm lacking tons of context here.

There's this other theme, Storefront, a theme with theme supports and no color palette, for which the theme palette is still shown

This bug is independent from this PR and I've got a fix at #36054