The Wayback Machine - https://web.archive.org./web/20210206104638/https://github.com/TheAlgorithms/C-Plus-Plus/pull/1247
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create house_robber.cpp #1247

Open
wants to merge 5 commits into
base: master
from

Conversation

@SumukhBhardwaj
Copy link

@SumukhBhardwaj SumukhBhardwaj commented on Oct 10, 2020

Added House Robber problem, solved using dynamic programming

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@kvedala
Copy link
Collaborator

@kvedala kvedala commented on Oct 11, 2020

Does your code conform to the standards and the checklist?
image

@SumukhBhardwaj
Copy link
Author

@SumukhBhardwaj SumukhBhardwaj commented on Oct 11, 2020

Does your code conform to the standards and the checklist?
image

Yes I have added enough comments and also take care of naming conventions.

@kvedala
Copy link
Collaborator

@kvedala kvedala commented on Oct 11, 2020

It does not follow the repo standards. All the details are provided in the links in the checklist. Please review and update the code accordingly. No reviews will be provided until the code is updated to the repo standards.
Thank you for your contribution.

added test cases and solution description
@SumukhBhardwaj
Copy link
Author

@SumukhBhardwaj SumukhBhardwaj commented on Oct 11, 2020

It does not follow the repo standards. All the details are provided in the links in the checklist. Please review and update the code accordingly. No reviews will be provided until the code is updated to the repo standards.
Thank you for your contribution.

Please review now, i have added test cases and solution as well.

Refactored code
Refactored code
@SumukhBhardwaj
Copy link
Author

@SumukhBhardwaj SumukhBhardwaj commented on Oct 11, 2020

@kvedala please review it now. I have done all the required changes.

Refactored code
Copy link
Collaborator

@kvedala kvedala left a comment

👍
Good update but much needs to be done still. Please review the comments thoroughly.

@@ -0,0 +1,95 @@
/*House Robber - Dynamic Programming

This comment has been minimized.

@kvedala

kvedala on Oct 16, 2020
Collaborator

Suggested change
/*House Robber - Dynamic Programming
/**
* @file
* @brief House Robber - Dynamic Programming

Update the documetnation block per the guidelines. A sample code is provided for your convenience. In the above comment, an example existing code was also provided as a reference.


/**
* @brief This function implements the above algorithm
* @money array of numbers containing the money in the ith house

This comment has been minimized.

@kvedala

kvedala on Oct 16, 2020
Collaborator

the doc blocks are not per the requested, suggested and described in the guidelines. refer to the comment above.

The "This" does not reflect in the documentation. You can review the documentation site: http://thealgorithms.github.io/C-Plus-Plus
You can split the file and function documentations. See this file for example. Also note the use of namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants