Ticket #1227 (closed enhancement: fixed)

Opened 21 months ago

Last modified 16 months ago

In Topic.php, posters' name should be hyperlinked to profiles by default

Reported by: grassrootspa Owned by:
Priority: normal Milestone: 1.1
Component: Front-end Version: 1.0.2
Severity: minor Keywords: has-patch tested
Cc: nightgunner5@…, matveb

Description

On the topic discussion pages (topic.php) posters' names are not hyperlinked to their respective profiles by default.

This makes very little sense. The most obvious place/situation where one would be tempted to look at a posters' profile is right after reading a post they have made under a topic thread.

One cannot do that if the poster's name is not hyperlinked to their profile!

Attachments

1227.patch Download (2.1 KB) - added by Nightgunner5 21 months ago.
Allow users to decide whether the name and avatar should link to the profile or the website.
1227-rel.diff Download (2.1 KB) - added by matveb 21 months ago.
1277.diff Download (3.9 KB) - added by GautamGupta 16 months ago.
Better Patch

Change History

  • Cc nightgunner5@… added
  • Status changed from new to closed
  • Resolution set to invalid

Click on their title, for example "Member".

The username is linked to their website by default.

I understand where you are coming from nightgunner5, but doesn't it make much more sense to hyperlink the user name to the profile rather than hyperlink their title to their profile?

The current setup doesn't make very much sense to me. Take Facebook for example: when two people have a wall exchange you click on a person's name to get to their profile, not something else. Same with Twitter. It makes little sense not to hyperlink a poster's name so it leads to their profile.

An outside observer would probably expect the title to go to a page explaining the title rather than the profile.

Follow me?

  • Status changed from closed to reopened
  • Resolution invalid deleted

Allow users to decide whether the name and avatar should link to the profile or the website.

  • Keywords has-patch added

+ 1 for implementing this.

Corrected the relationship (website was pointing to profile and viceversa) and changed the order to Website first.

  • Cc matveb added
  • Keywords dev-feedback added
  • Type changed from defect to enhancement
  • Severity changed from normal to minor
  • Keywords topic.php profile link poster removed
  • Version changed from 1.0.1 to 1.0.2

Better Patch

  • Keywords tested added; dev-feedback removed

The patch by NightGunner5 edited the gravatar link which I think the ticket doesn't intend to do. I have attached another patch which also has some fixes for the settings page, a note about the new option (telling what would it do) and correcting the place of link.

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [2431]) Link author's name to their profile page in topic.php. Fixes #1227. Props grassrootspa for the report, Nightgunner5 for the first path, GautamGupta? for the final patch

Note: See TracTickets for help on using tickets.