Skip to content

/ scaffold-command

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent creating unregisterable blocks due to invalid plugin slug #203

Merged
merged 3 commits into from Apr 21, 2019
Merged

Prevent creating unregisterable blocks due to invalid plugin slug #203

merged 3 commits into from Apr 21, 2019

Conversation

@kuoko
Copy link
Contributor

@kuoko kuoko commented Apr 5, 2019

The purpose of this PR is to prevent nonworking gutenberg blocks.
More details here: #191
@kuoko
prevent nonworking gutenberg block
Loading status checks…
51a8980
@kuoko kuoko requested a review from wp-cli/committers as a code owner Apr 5, 2019
@schlessera
schlessera requested changes Apr 5, 2019
View changes
src/Scaffold_Command.php Outdated Show resolved Hide resolved
@schlessera @kuoko
Update src/Scaffold_Command.php
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b460a3f 
Co-Authored-By: kuoko <kuoko@users.noreply.github.com>
@schlessera schlessera added this to the 2.0.5 milestone Apr 5, 2019
@schlessera
schlessera approved these changes Apr 5, 2019
View changes
@schlessera schlessera changed the title prevent nonworking gutenberg blocks Prevent creating unregisterable blocks due to invalid plugin slug Apr 5, 2019
@schlessera
Merge branch 'master' into prevent-nonworking-gutenberg-blocks
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
c39d899
@schlessera schlessera merged commit 86ee481 into wp-cli:master Apr 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera
Copy link
Member

@schlessera schlessera commented Apr 21, 2019

Thanks for the PR, @kuoko !
@schlessera schlessera mentioned this pull request Apr 23, 2019
Closed
@kuoko
Copy link
Contributor Author

@kuoko kuoko commented Apr 24, 2019

It was a pleasure. @schlessera
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera

Assignees
No one assigned
Labels
scope:documentation
Milestone
2.0.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kuoko @schlessera
You can’t perform that action at this time.