Skip to content

/ media-command

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changes in WP 5.3 image handling to fix broken tests #115

Merged
merged 9 commits into from Sep 25, 2019
Merged

Adapt to changes in WP 5.3 image handling to fix broken tests #115

merged 9 commits into from Sep 25, 2019
+128 −16

Conversation

@schlessera
Copy link
Member

schlessera commented Sep 25, 2019

  • Uses new wp_get_original_image_path() function to retrieve filepath to images.
  • Skips media reorientation tests on WP 5.3+, as this is done by Core already.
  • Adapts to newly added image size 2048x2048
schlessera added 3 commits Sep 24, 2019
@schlessera
Adapt to newly added image size 2048x2048
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
a5d2323
@schlessera
Skip media reorientation tests on WP 5.3+
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
1f4f058
@schlessera
Use new wp_get_original_image_path() function to retrieve filepath to…
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
469597c 
… images
@schlessera schlessera requested a review from wp-cli/committers as a code owner Sep 25, 2019
@schlessera
Fix variable misnaming
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
b78cf47
@schlessera schlessera added this to the 2.0.5 milestone Sep 25, 2019
schlessera added 4 commits Sep 25, 2019
@schlessera
Adapt test to account for the two differing behaviors across versions
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
c5f3f9e
@schlessera
Add comment to separate set of tests
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
20373fc
@schlessera
Split tests for image sizes in two as well
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
82164f5
@schlessera
Add lower bound to compat size tests
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
5df2a9f
@swissspidy
swissspidy reviewed Sep 25, 2019
View changes
package-lock.json Outdated Show resolved Hide resolved
@schlessera
Remove accidentally added package lock file
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
ba9f358
@schlessera schlessera requested a review from wp-cli/committers Sep 25, 2019
@swissspidy
swissspidy approved these changes Sep 25, 2019
View changes
@swissspidy swissspidy merged commit 98102a5 into master Sep 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@swissspidy swissspidy deleted the fix-test-failures-with-5-3-beta-1 branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy

Assignees
No one assigned
Labels
bug command:media-import command:media-regenerate scope:testing
Milestone
2.0.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@schlessera @swissspidy
You can’t perform that action at this time.