Skip to content

/ extension-command

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the `--page` parameter to the `theme search` command #167

Merged
merged 3 commits into from Apr 21, 2019
Merged

Add the `--page` parameter to the `theme search` command #167

merged 3 commits into from Apr 21, 2019

Conversation

@amieiro
Copy link
Contributor

@amieiro amieiro commented Apr 17, 2019

Fix the #166 bug: the "wp theme search" command has not the "page" option
amieiro added 2 commits Apr 16, 2019
@amieiro
Add the --page parameter to the docblock of the theme search command
9a989d5 
Fix the #166 bug:
the "wp theme search" command has not the "page" option
@amieiro
Regenerate the README.md file
Loading status checks…
5bc2fd9
@amieiro amieiro requested a review from wp-cli/committers as a code owner Apr 17, 2019
@schlessera
schlessera requested changes Apr 17, 2019
View changes
Copy link
Member

@schlessera schlessera left a comment

Hehe, looks like our README.md was not fully up-to-date... ;)

The PR looks good except for the indentation in the docblock. Please use tabs there.
src/Theme_Command.php Outdated Show resolved Hide resolved
@schlessera schlessera changed the title Add the --page parameter to the theme search command Add the `--page` parameter to the `theme search` command Apr 17, 2019
@amieiro
Change the spaces by tabs in the indentation
Loading status checks…
217924a
@schlessera
schlessera approved these changes Apr 21, 2019
View changes
@schlessera schlessera merged commit c8556c1 into wp-cli:master Apr 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera
Copy link
Member

@schlessera schlessera commented Apr 21, 2019

Thanks for the PR, @amieiro !
@schlessera schlessera added this to the 2.0.4 milestone Apr 21, 2019
@amieiro amieiro mentioned this pull request Apr 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera

Assignees
No one assigned
Labels
bug command:theme-search
Milestone
2.0.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@amieiro @schlessera
You can’t perform that action at this time.