Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Handle extension activation for WP error or extension not found #146
+25
−2
Conversation
|
Thanks for the PR, @abhijitrakas! Can you think of a way to write a test for this change so that we can verify its behavior and guard against regressions? |
src/WP_CLI/CommandWithUpgrade.php
Outdated
| @@ -210,7 +210,10 @@ public function install( $args, $assoc_args ) { | |||
| } | |||
| } | |||
|
|
|||
| if ( $result ) { | |||
| // Check plugin is available or not. | |||
| $plugin = $this->fetcher->get_many( array( $slug ) ); | |||
schlessera
Mar 21, 2019
Member
This could just as well be a theme here, so better use the term extension instead:
Suggested change
$plugin = $this->fetcher->get_many( array( $slug ) );
$extension = $this->fetcher->get_many( array( $slug ) );
This could just as well be a theme here, so better use the term extension instead:
Suggested change
| $plugin = $this->fetcher->get_many( array( $slug ) ); | |
| $extension = $this->fetcher->get_many( array( $slug ) ); |
src/WP_CLI/CommandWithUpgrade.php
Outdated
| // Check plugin is available or not. | ||
| $plugin = $this->fetcher->get_many( array( $slug ) ); | ||
|
|
||
| if ( ! is_wp_error( $result ) && count( $plugin ) > 0 ) { |
schlessera
Mar 21, 2019
Member
Suggested change
if ( ! is_wp_error( $result ) && count( $plugin ) > 0 ) {
if ( ! is_wp_error( $result ) && count( $extension ) > 0 ) {
Suggested change
| if ( ! is_wp_error( $result ) && count( $plugin ) > 0 ) { | |
| if ( ! is_wp_error( $result ) && count( $extension ) > 0 ) { |
|
@schlessera PR Updated. Thanks. |
|
Thanks for the PR, @abhijitrakas ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
closes #127