Welcome to the official blog for the Plugin Review Team.
The review team acts as gate-keepers and fresh eyes on newly submitted plugins, as well as reviewing any reported security or guideline violations.
Quick Links
The review team acts as gate-keepers and fresh eyes on newly submitted plugins, as well as reviewing any reported security or guideline violations.
Quick Links
X-comment from +make.wordpress.org/updates: Comment on Daylight Saving Time Meeting Planning
X-comment from +make.wordpress.org/updates: Comment on WCEU 2020 ā Leave no Contributor Behind
Instagram is accelerating the end of their current API.
Per a notice on https://www.instagram.com/developer/ no new clients can register, and soon some basic functionality will be changed.
We will be reviewing plugins that call these functionalities and, if they are not updated, will close them in order to prevent adverse impact on users.
If you know youāre not going to want to fix this, please email plugins@wordpress.org
, provide a link to the plugin, and tell us youād like us to close it. We know that Instgram (and Facebook) have been difficult to work with this last year, and fully respect and support your decisions here with regards to your plugins.
Here is Instagramās announcement:
UPDATE: Starting October 15, 2019, new client registration and permission review on Instagram API platform are discontinued in favor of the Instagram Basic Display API.
To continuously improve Instagram usersā privacy and security, we are accelerating the deprecation of Instagram API Platform, making the following changes effective immediately. We understand that this may affect your business or services, and we appreciate your support in keeping our platform secure.
These capabilities will be disabled immediately (previously set for July 31, 2018 or December 11, 2018 deprecation). The following will be deprecated according to the timeline we shared previously:
- Public Content ā all remaining capabilities to read public media on a userās behalf on December 11, 2018
- Basic ā to read a userās own profile info and media in early 2020
For your reference, information on the new Instagram Graph API.
Thereās been a lot of quiet change going on for Plugins, so now is as good a time as any to get into it!
If youāre interested in any details missing, leave a comment. I do ask you try not to speculate too much into the whyās and wherefores of what people do with plugins. Iāve been at this a while, and the one thing I can promise is people do weird things.
We finally migrated off of the old system and on to HelpScout in March, which allows us the ability to sort and organize emails into teams. It also lets us properly filter bad actors so not everyone has to deal with them. We make heavy use of automated filters now, which has let us do the impossible ā¦
We onboarded two new team members in November and have been easing them in to the weird workload of Plugins. Theyāve been instrumental in sorting out what filters and team assignments do and donāt work well for Plugins.
Iāve been using a new bash script to expedite scanning plugins. While weād love to use WPCS (and I personally recommend it to for everyone), even with a heavily parred down version it hasnāt quite met our needs. The goal for next year is to move the bash script into a PHP plugin we can use to automate a lot more.
Our saved replies (the standard ones you get for closures and reviews) have all been cleaned up, spellchecked, and formatted for easier reading. Now, when you get an alert that your plugin has been closed, we attempt to direct you on exactly how to resolve the issues. This is still a bit of a work in progress, but weāve made great strides on consistent tone and softer language.
Sadly as many people found out, we got dinged hard by some trademark owners, and are taking action against people who violate trademarks. Around 1000 plugins were closed due to that, and itās one of those things we canāt protect you from. Weāve changed the plugin uploader for new submissions to block a lot of that.
Remember the basic rule: If itās not your company/product/library, donāt begin your plugin Display Name or permalink with it!
(Trademark owners: Please ask the developer to changes things before coming to us. Communication will help everyone.)
A lot of people like this part. Hereās the overall outlook from 2019:
And in a slightly more consumable summary table:
Requested | Rejected | Closed | Approved | Pending | |
Most in a week | 194 | 109 | 480 | 118 | 718 |
Least in a week | 129 | 2 | 9 | 25 | 527 |
Average | 161 | 25 | 117 | 76 | 623 |
Year to Date | 8048 | 1221 | 6038 | 3836 | N/A |
Weāve had 1000 more plugins submitted in 2019 than 2018, however the Rejected and Approved numbers only went up by 100.
So where are the extra 800 plugins? On average, pending plugins did go down but only by about 25 a week. Most of the missing counts are there, but theyāre also in the dreaded āClosedā section.
A higher than expected number of developers have submitted plugins for review and then asked them to be closed within a 6 month timeframe. This has led to us pushing back on people and making notes in their accounts about that kind of behavior. There hasnāt yet been a common thread to why thatās happening, so weāre keeping an eye out.
HelpScout also helpfully provides their own statistics for how much we used them. This is just since March when we switched over:
We make heavy use of Saved Replies to speed up reviews and processing. These were brought in to use in chunks, and Iām omitting the exact numbers. They wonāt do you any good to know we sent 2,679 āApproval after sendā emails when you realize we also only sent 628 āIntro to new Reviewā. All that means is we pulled in the Approval email first. Next year these stats will be more useful.
All that said, I think having a look at what the most common sorts of issues are might be a little enlightening. Everything is ordered from most use to least.
These emails are sent out when a plugin is closed or the developer needs to be warned about issues/behavior.
All these emails are sent when a plugin is being reviewed.
A pended plugin is one we stop before even reviewing the code. This usually happens because someoneās infringing on trademarks, or using a personal account to submit a company owned plugin.
This should give you an idea of why plugins are rejected. Top of the list? People who donāt reply.
The rest of the emails are lumped together. Youāll notice we have prefixes to what each email is. That helps us find them faster.
Posting here with a journal entry for reference: I was pinged in a few tweet storms in the past week, so I took the liberty of reviewing the email template that seemed to kick off both conversations (sockpuppet activity). I edited it for clarity, flow, and WordPress Voice. The issues that prompted the complaints on Twitter have also been resolved through direct communication.
X-comment from +make.wordpress.org/core: Comment on Use of the "wp_update_attachment_metadata" filter as "upload is complete" hook
X-comment from +make.wordpress.org/core: Comment on WP 5.3: Introducing the spread operator
X-comment from +make.wordpress.org/test: Comment on Calling all testing plugins
X-comment from +make.wordpress.org/core: Comment on Component Maintainers in 5.3