Optimize computing filename in LiquidRenderer #6841
Conversation
| @@ -53,7 +53,7 @@ def self.format_error(e, path) | |||
| private | |||
|
|
|||
| def filename_regex | |||
| %r!\A(#{source_dir}/|#{theme_dir}/|\W*)(.*)!oi | |||
| @filename_regex ||= %r!\A(#{source_dir}/|#{theme_dir}/|\W*)(.*)!i | |||
There was a problem hiding this comment.
Just curious: Why did you get rid of the o modifier?
There was a problem hiding this comment.
The o modifier stands for "interpolate once" which I feel is *unnecessary" when the regex itself is going to be created once per Site instance since the entire method has now been memoized..
| def_delegator :@site, :in_source_dir, :source_dir | ||
| def_delegator :@site, :in_theme_dir, :theme_dir | ||
| private def_delegator :@site, :in_source_dir, :source_dir | ||
| private def_delegator :@site, :in_theme_dir, :theme_dir |
There was a problem hiding this comment.
I recognize that these were always meant to be private, but at this point would it be easier to punt this until v4.0.0? Or is this necessary for this PR?
There was a problem hiding this comment.
These attributes have not been released yet.. I added them in #6610..
So they can be safely altered..
There was a problem hiding this comment.
(this is therefore just a fix as well..)
|
@jekyllbot: |
+minor
I should've made these corrections before #6610 got merged..
Oh well.."Better late than never.."