/jekyll

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix inaccurate HTTP response header field name #4976

Merged
merged 2 commits into from Jun 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
bug documentation enhancement
Projects
None yet
Milestone
No milestone
3 participants
@galopin @envygeeks @jekyllbot
@galopin
Contributor

galopin commented Jun 2, 2016 • edited

Custom WEBrick headers default settings documentation is incorrect.

“We only provide one default and that’s a Content-Type header that disables caching in development […]”

should read:

“We only provide one default and that’s a Cache-Control header that disables caching in development […]”

Cf. https://github.com/jekyll/jekyll/blob/master/lib/jekyll/commands/serve/servlet.rb#L8-9
@galopin galopin Fix inaccurate HTTP response header field name 
§ Custom WEBrick headers default settings
Cf. ./lib/jekyll/commands/serve/servlet.rb
899316f
@envygeeks
Contributor

envygeeks commented Jun 2, 2016

@galopin actually that is correct to an extent, it's correct in that we do provide Content-Type, but it's not right that we only provide it, we actually provide by default Content-Type _and_ Cache-Control, one dynamic, the other static: https://github.com/jekyll/jekyll/blob/master/lib/jekyll/commands/serve/servlet.rb#L40

Do you mind updating the pull request to reflect that?
Thanks!

envygeeks added bug enhancement pending-feedback labels Jun 2, 2016

@galopin
Contributor

galopin commented Jun 3, 2016 • edited

@envygeeks thank you for the clarification 💡 I updated this pull request as requested.

jekyllbot removed the pending-feedback label Jun 3, 2016

@envygeeks
Contributor

envygeeks commented Jun 3, 2016

❤️

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit bf524d6 into jekyll:master Jun 3, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added the documentation label Jun 3, 2016

@jekyllbot jekyllbot added a commit that referenced this pull request Jun 3, 2016

@jekyllbot jekyllbot Update history to reflect merge of #4976 [ci skip] b15423b

galopin deleted the galopin:patch-1 branch Jun 3, 2016

@parkr parkr added a commit that referenced this pull request Jun 4, 2016

@parkr parkr Merge branch 'master' into percent_r 
* master: (22 commits)
  Update history to reflect merge of #4980 [ci skip]
  werdz
  Use jekyll-mentions and restructure
  Add post about GSoC project.
  Update history to reflect merge of #4976 [ci skip]
  Amend WEBrick default headers documentation
  Update history to reflect merge of #4966 [ci skip]
  .rubocop.yml - remove lib/jekyll.rb
  lib/jekyll.rb - fix offenses reported by rubocop method set_timezone is ignored using rubocop:disable Style/AccessorMethodName
  Update history to reflect merge of #4977 [ci skip]
  Update history to reflect merge of #4962 [ci skip]
  Update history to reflect merge of #4959 [ci skip]
  Fixed typo
  Changed github-gem to github-pages
  Included installation instructions
  Installation instructions for github-pages gem
  Added link to windows doc page
  Fix inaccurate HTTP response header field name
  Minor tweak to fix missing apostrophne
  Feedback for flubbed regex and prefer File's directory check
  ...
This commit was signed with a verified signature.
@parkr parkr Parker Moore
GPG key ID: 193CDEBA72063C58 Learn about signing commits
8917fa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment