Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Refactor post and draft object creation #1779
Conversation
|
/cc @pzula because she helped. |
|
LOL!! didn't even think about that. On Thu, Dec 5, 2013 at 11:28 PM, Parker Moore notifications@github.com
|
|
One of the main reasons I For reference, the error:
|
|
|
|
@mattr- Can we move back to using just plain |
|
@mattr- Actually, I'm going to give good ol' |
|
@mattr- I've changed our enumerator and the tests all pass. However, I've never tried to update a PR before that was not my own... I have made the code changes in my fork here: pzula/jekyll@440d3fd but am unsure as to how to add it to this pull request? Do I open a new request? |
|
@pzula Cherry-picked your commit into this branch. All set! |
|
The failures I saw from the previous push were re: TOML stuff which I already fixed on |
mattr-
added a commit
that referenced
this pull request
Dec 7, 2013
|
|
mattr- |
362d28f
|
mattr-
merged commit 362d28f
into
master
Dec 7, 2013
mattr-
deleted the
no-duplication branch
Dec 7, 2013
mattr-
added a commit
that referenced
this pull request
Dec 7, 2013
|
|
mattr- |
8b0ea62
|
parkr
commented on the diff
Dec 9, 2013
| - # first pass processes, but does not yet render post content | ||
| - entries.each do |f| | ||
| - if Post.valid?(f) | ||
| - post = Post.new(self, self.source, dir, f) | ||
| - | ||
| - if post.published && (self.future || post.date <= self.time) | ||
| - aggregate_post_info(post) | ||
| - end | ||
| + posts.each do |post| | ||
| + if post.published && (self.future || post.date <= self.time) |
mattr-
Owner
|
mattr- commentedDec 6, 2013
De-duplicate object creation between posts and drafts. Inject the name
dependency through a parameter