22 Pull requests merged by 15 people

• validation: Make translations of fatal errors consistent

  #29672 merged Mar 22, 2024

• rpc: "addpeeraddress tried" return error on failure

  #28998 merged Mar 22, 2024

• test: make p2p_handshake robust against timeoffset warnings

  #29704 merged Mar 22, 2024

• Avoid divide-by-zero in header sync logs when NodeClock is behind

  #29647 merged Mar 22, 2024

• [25.x] backports

  #29531 merged Mar 22, 2024

• doc: Rename `contrib/devtools/bitcoin-tidy/README` to `README.md`

  #29703 merged Mar 22, 2024

• guix: bump time-machine to dc4842797bfdc5f9f3f5f725bf189c2b68bd6b5a

  #29651 merged Mar 21, 2024

• index: avoid "failed to commit" errors on initialization

  #29671 merged Mar 20, 2024

• assumeutxo: Get rid of faked nTx and nChainTx values

  #29370 merged Mar 20, 2024

• blockstorage: do not flush block to disk if it is already there

  #27039 merged Mar 20, 2024

• index: block filters sync, reduce disk read operations by caching last header

  #28955 merged Mar 20, 2024

• ci: Bump msan to llvm-18

  #29676 merged Mar 20, 2024

• test: p2p: check disconnect due to lack of desirable service flags

  #29279 merged Mar 19, 2024

• Weaken serfloat tests

  #29192 merged Mar 19, 2024

• ci: Better tidy errors

  #29094 merged Mar 19, 2024

• test: fix intermittent failures with test=addrman

  #29639 merged Mar 19, 2024

• fuzz: actually test garbage >64b in p2p transport test

  #29667 merged Mar 19, 2024

• RPC: Add maxfeerate and maxburnamount args to submitpackage

  #28950 merged Mar 18, 2024

• ci: Drop `--enable-c++20` option

  #29669 merged Mar 18, 2024

• ci: Bump `TIDY_LLVM_V`

  #29659 merged Mar 18, 2024

• build: Bump g++ minimum supported version to 11

  #29091 merged Mar 18, 2024

• lint: Misc improvements for lint runner

  #29537 merged Mar 18, 2024

23 Pull requests opened by 13 people

• prune, rpc: Check undo data when finding pruneheight

  #29668 opened Mar 17, 2024

• guix: use GCC 11 in macOS build env

  #29673 opened Mar 18, 2024

• wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys

  #29675 opened Mar 18, 2024

• Bugfix: Correct first-run free space checks

  #29678 opened Mar 19, 2024

• wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict

  #29680 opened Mar 20, 2024

• test: loading assumeutxo snapshot with current chaintip at snapshot_base_height

  #29681 opened Mar 20, 2024

• Update manpage descriptions

  #29686 opened Mar 21, 2024

• cli: improve bitcoin-cli error when not connected

  #29687 opened Mar 21, 2024

• test: remove duplicated ban test

  #29688 opened Mar 21, 2024

• lint: scripted-diff verification also requires GNU grep

  #29689 opened Mar 21, 2024

• clang-tidy: Enable misc-no-recursion

  #29690 opened Mar 21, 2024

• Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us

  #29691 opened Mar 21, 2024

• [27.x] Further Backports

  #29693 opened Mar 21, 2024

• fuzz: wallet: add target for spkm migration

  #29694 opened Mar 21, 2024

• guix: build GCC with --enable-standard-branch-protection

  #29695 opened Mar 21, 2024

• tidy: remove todo, set minimum CMake to 3.22

  #29696 opened Mar 21, 2024

• Fix typo in expat.mk.

  #29698 opened Mar 21, 2024

• test: check disconnection when sending sendaddrv2 after verack

  #29699 opened Mar 21, 2024

• kernel, refactor: return error status on all fatal errors

  #29700 opened Mar 21, 2024

• fees: Remove CLIENT_VERSION serialization

  #29702 opened Mar 22, 2024

• depends: set two CMake options globally

  #29706 opened Mar 22, 2024

• depends: build miniupnpc with CMake

  #29707 opened Mar 22, 2024

• depends: build libnatpmp with CMake

  #29708 opened Mar 22, 2024

13 Issues closed by 7 people

• .

  #29710 closed Mar 23, 2024

• .

  #29705 closed Mar 22, 2024

• .

  #29683 closed Mar 20, 2024

• assumeutxo: nTx and nChainTx violations in CheckBlockIndex

  #29261 closed Mar 20, 2024

• -reindex fails if blk0*.dat files read-only

  #2039 closed Mar 20, 2024

• Bitcoin Cross-compilation failed with errors in notification.cpp

  #29682 closed Mar 20, 2024

• fuzz: msan fuzz CI currently broken on x86_64

  #28570 closed Mar 20, 2024

• brew: serfloat_tests tests fail on Linux

  #28941 closed Mar 19, 2024

• feature_asmap.py intermittent fail ( AssertionError: [node 0] Expected messages "['CheckAddrman: new 2, tried 2, total 4 started', 'CheckAddrman: completed']" does not partially match log:)

  #29634 closed Mar 19, 2024

• where to find the official tutorial config file guide

  #29674 closed Mar 19, 2024

• .

  #29677 closed Mar 19, 2024

• submitpackage: add args "maxfeerate" and "maxburnamount"

  #28949 closed Mar 18, 2024

• Current default settings are broken, some fix is needed

  #29603 closed Mar 18, 2024

5 Issues opened by 4 people

• Wallet: Nondescript error message for 502nd unconfirmed transaction

  #29711 opened Mar 23, 2024

• v27.0 Testing

  #29697 opened Mar 21, 2024

• Historical scripted-diff failures (trivial)

  #29692 opened Mar 21, 2024

• 27.0 RC Testing Guide Feedback

  #29685 opened Mar 21, 2024

• contrib/signet/getcoins.py no longer useable

  #29679 opened Mar 20, 2024

150 Unresolved conversations

Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.

• Simplify network-adjusted time warning logic

  #29623 commented on Mar 23, 2024 • 53 new comments

• Mempool util: Add RBF diagram checks for single chunks against clusters of size 2

  #29242 commented on Mar 20, 2024 • 39 new comments

• wallet: Add `createwalletdescriptor` and `gethdkeys` RPCs for adding new automatically generated descriptors

  #29130 commented on Mar 20, 2024 • 23 new comments

• p2p: opportunistically accept 1-parent-1-child packages

  #28970 commented on Mar 23, 2024 • 22 new comments

• index: blockfilter initial sync speedup, parallelize process

  #26966 commented on Mar 23, 2024 • 20 new comments

• Wallet: Add `max_tx_weight` to transaction funding options (take 2)

  #29523 commented on Mar 22, 2024 • 17 new comments

• lint: Fix COMMIT_RANGE issues

  #29660 commented on Mar 22, 2024 • 15 new comments

• test: adds outbound eviction functional tests, updates comment in ConsiderEviction

  #29122 commented on Mar 23, 2024 • 13 new comments

• Wallet: Add `maxfeerate` wallet startup option

  #29278 commented on Mar 20, 2024 • 13 new comments

• Broadcast own transactions only via short-lived Tor or I2P connections

  #29415 commented on Mar 23, 2024 • 9 new comments

• kernel: Handle fatal errors through return values

  #29642 commented on Mar 21, 2024 • 7 new comments

• Don't empty dbcache on prune flushes: >30% faster IBD

  #28280 commented on Mar 22, 2024 • 7 new comments

• validation: improve performance of CheckBlockIndex

  #28339 commented on Mar 21, 2024 • 7 new comments

• wallet: optimize migration process, batch db transactions

  #28574 commented on Mar 22, 2024 • 7 new comments

• Remove libbitcoinconsensus

  #29648 commented on Mar 21, 2024 • 7 new comments

• p2p: gives seednode priority over dnsseed if both are provided

  #28016 commented on Mar 23, 2024 • 6 new comments

• rpc: rollback

  #29565 commented on Mar 18, 2024 • 6 new comments

• test: fix `keys_to_multisig_script` (P2MS) helper for n/k > 16

  #28312 commented on Mar 20, 2024 • 6 new comments

• test: add coverage for bech32m in `wallet_keypool_topup`

  #28928 commented on Mar 20, 2024 • 6 new comments

• chainparams: Change nChainTx type to uint64_t

  #29656 commented on Mar 23, 2024 • 6 new comments

• wallet: track mempool conflicts with wallet transactions

  #27307 commented on Mar 20, 2024 • 5 new comments

• Show transactions as not fully confirmed during background validation

  #28616 commented on Mar 21, 2024 • 5 new comments

• V2 Only Option

  #29618 commented on Mar 19, 2024 • 5 new comments

• AssumeUTXO Mainnet Readiness Tracking

  #29616 commented on Mar 20, 2024 • 4 new comments

• test: rpc: add last block announcement time to getpeerinfo result

  #27052 commented on Mar 23, 2024 • 4 new comments

• wallet: Avoid potentially writing incorrect best block locator

  #29652 commented on Mar 20, 2024 • 3 new comments

• refactor: Remove gmtime*

  #29081 commented on Mar 19, 2024 • 3 new comments

• test: #29007 follow ups

  #29636 commented on Mar 23, 2024 • 3 new comments

• assumeutxo: Add dumptxoutset height param, remove shell scripts

  #29553 commented on Mar 23, 2024 • 3 new comments

• blockstorage: XOR blocksdir *.dat files

  #28052 commented on Mar 22, 2024 • 3 new comments

• doc: update release-process.md

  #29645 commented on Mar 22, 2024 • 3 new comments

• net_processing: make any misbehavior trigger immediate discouragement

  #29575 commented on Mar 23, 2024 • 3 new comments

• improve MallocUsage() accuracy

  #28531 commented on Mar 22, 2024 • 3 new comments

• scripted-diff: Use LogInfo/LogDebug over LogPrintf/LogPrint

  #29641 commented on Mar 22, 2024 • 2 new comments

• Several randomness improvements

  #29625 commented on Mar 23, 2024 • 2 new comments

• test: Validate UTXO snapshot with coin height > base height & amount > MAX_MONEY supply

  #29617 commented on Mar 20, 2024 • 2 new comments

• rpc: Optimize serialization disk space of dumptxoutset - Reloaded

  #29612 commented on Mar 23, 2024 • 2 new comments

• Drop -dbcache limit

  #28358 commented on Mar 18, 2024 • 2 new comments

• net: Favor peers from addrman over fetching seednodes

  #29605 commented on Mar 23, 2024 • 2 new comments

• C++20 std::views::reverse

  #28687 commented on Mar 23, 2024 • 2 new comments

• p2p: Fill reconciliation sets (Erlay)

  #28765 commented on Mar 21, 2024 • 2 new comments

• net: attempts to connect to all resolved addresses when connecting to a node

  #28834 commented on Mar 22, 2024 • 2 new comments

• Bugfix: bitcoin-cli: Check length of peer.transport_protocol_type

  #29657 commented on Mar 17, 2024 • 2 new comments

• depends: add -g to DEBUG=1 flags

  #29527 commented on Mar 18, 2024 • 2 new comments

• Support self-hosted Cirrus workers on forks

  #29274 commented on Mar 22, 2024 • 2 new comments

• build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set

  #25972 commented on Mar 20, 2024 • 2 new comments

• Error: Cannot resolve -bind address: 'bitcoind:8334=onion'

  #26484 commented on Mar 20, 2024 • 2 new comments

• Consideration of a Code of Conduct and/or written rules for moderation

  #29507 commented on Mar 21, 2024 • 2 new comments

• indexes: Stop using node internal types and locking cs_main, improve sync logic

  #24230 commented on Mar 20, 2024 • 2 new comments

• test: extend the SOCKS5 Python proxy to actually connect to a destination

  #29420 commented on Mar 18, 2024 • 1 new comment

• Stratum v2 Template Provider (take 3)

  #29432 commented on Mar 23, 2024 • 1 new comment

• wallet: Target a pre-defined utxo set composition by adjusting change outputs

  #29442 commented on Mar 22, 2024 • 1 new comment

• Remove the legacy wallet and BDB dependency

  #28710 commented on Mar 18, 2024 • 1 new comment

• refactor: Add util::Result failure values, multiple error and warning messages

  #25665 commented on Mar 23, 2024 • 1 new comment

• Replace Boost.Process with cpp-subprocess

  #28981 commented on Mar 21, 2024 • 1 new comment

• test: Handle functional test disk-full error

  #29335 commented on Mar 22, 2024 • 1 new comment

• tidy: enable `cppcoreguidelines-pro-type-member-init`

  #27315 commented on Mar 22, 2024 • 1 new comment

• rpc: improve submitpackage documentation and other improvements

  #29292 commented on Mar 20, 2024 • 1 new comment

• Since 0.16 Bitcoin can be stuck connected to adversarial/3rdparty node

  #29506 commented on Mar 22, 2024 • 1 new comment

• -Wmaybe-uninitialized warnings under LTO

  #27343 commented on Mar 21, 2024 • 1 new comment

• Fix tiebreak when loading blocks from disk (and add tests for comparing chain ties)

  #29640 commented on Mar 22, 2024 • 1 new comment

• util-{util,wallet}: undefined reference to `evhttp_uridecode'

  #29654 commented on Mar 18, 2024 • 1 new comment

• validation: don't clear cache on periodic flush

  #28233 commented on Mar 22, 2024 • 1 new comment

• logging: Update to new logging API

  #29231 commented on Mar 23, 2024 • 1 new comment

• More control of maintenance processes at startup/restart

  #29662 commented on Mar 20, 2024 • 1 new comment

• wallet: Keep track of the wallet's own transaction outputs in memory

  #27286 commented on Mar 20, 2024 • 1 new comment

• reduce cs_main scope, guard block index 'nFile' under a local mutex

  #27006 commented on Mar 20, 2024 • 1 new comment

• ZMQ: Support UNIX domain sockets

  #27679 commented on Mar 22, 2024 • 1 new comment

• Policy: disallow P2PK transactions from relaying by default

  #29285 commented on Mar 20, 2024 • 1 new comment

• Bugfix: GUI: Help messages already have a trailing newline, so don't add an extra one

  #29658 commented on Mar 19, 2024 • 0 new comments

• rpc: provide per message stats for global traffic via new RPC 'getnetmsgstats'

  #29418 commented on Mar 23, 2024 • 0 new comments

• rpc: validate fee estimation mode case insensitive

  #29175 commented on Mar 19, 2024 • 0 new comments

• Implement 64 bit arithmetic op codes in the Script interpreter

  #29221 commented on Mar 19, 2024 • 0 new comments

• descriptors: Be able to specify change and receiving in a single descriptor string

  #22838 commented on Mar 22, 2024 • 0 new comments

• mempool: Log added for dumping mempool transactions to disk

  #29402 commented on Mar 23, 2024 • 0 new comments

• Make (Read/Write)BinaryFile work with char vector, use AutoFile

  #29229 commented on Mar 23, 2024 • 0 new comments

• test: fix RPC coverage check

  #29387 commented on Mar 19, 2024 • 0 new comments

• Stratum v2 Noise Protocol

  #29346 commented on Mar 22, 2024 • 0 new comments

• consensus: Store transaction nVersion as uint32_t

  #29325 commented on Mar 19, 2024 • 0 new comments

• CKey: add Serialize and Unserialize

  #29295 commented on Mar 19, 2024 • 0 new comments

• Add a "tx output spender" index

  #24539 commented on Mar 22, 2024 • 0 new comments

• Implement OP_CHECKTEMPLATEVERIFY

  #29280 commented on Mar 20, 2024 • 0 new comments

• build: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix)

  #24123 commented on Mar 22, 2024 • 0 new comments

• Package Relay Project Tracking

  #27463 commented on Mar 18, 2024 • 0 new comments

• Release schedule for 27.0

  #29028 commented on Mar 19, 2024 • 0 new comments

• 100,000 ṩ/vB is excessive as a sanity check on feerate

  #29661 commented on Mar 20, 2024 • 0 new comments

• CFilters reject and disconnect peers with a valid block hash

  #29655 commented on Mar 20, 2024 • 0 new comments

• [tests] Race between test code and code in net thread

  #29643 commented on Mar 20, 2024 • 0 new comments

• Prune Node Rescan Project Tracking

  #29183 commented on Mar 20, 2024 • 0 new comments

• Proposed Timeline for Legacy Wallet and BDB removal

  #20160 commented on Mar 21, 2024 • 0 new comments

• contrib: list other binaries in manpage output

  #29585 commented on Mar 21, 2024 • 0 new comments

• Prune locks

  #19463 commented on Mar 23, 2024 • 0 new comments

• validation: Use witness maleation flag for non-segwit blocks

  #29540 commented on Mar 17, 2024 • 0 new comments

• Refactor BnB tests

  #29532 commented on Mar 23, 2024 • 0 new comments

• Implement BIP 370 PSBTv2

  #21283 commented on Mar 19, 2024 • 0 new comments

• build: LLD based macOS toolchain

  #21778 commented on Mar 23, 2024 • 0 new comments

• test: create assert_not_equal util

  #29500 commented on Mar 19, 2024 • 0 new comments

• [DO NOT MERGE] Schnorr batch verification for blocks

  #29491 commented on Mar 19, 2024 • 0 new comments

• depends: always configure with `--with-pic`

  #29488 commented on Mar 23, 2024 • 0 new comments

• Drop log category in `SeedStartup`

  #29480 commented on Mar 23, 2024 • 0 new comments

• test: add missing tests for Assumeutxo

  #29428 commented on Mar 21, 2024 • 0 new comments

• log: deduplicate category names and improve logging.cpp

  #29419 commented on Mar 22, 2024 • 0 new comments

• net: don't lock cs_main while reading blocks in net processing

  #26326 commented on Mar 23, 2024 • 0 new comments

• net: additional disconnect logging

  #28521 commented on Mar 23, 2024 • 0 new comments

• wallet: Fix wallet directory initialization

  #28514 commented on Mar 23, 2024 • 0 new comments

• Do not log p2p bip61 reject messages, improve log, add tests

  #28429 commented on Mar 23, 2024 • 0 new comments

• contrib/signet/miner updates

  #28417 commented on Mar 22, 2024 • 0 new comments

• Fix waste calculation in SelectionResult

  #28366 commented on Mar 22, 2024 • 0 new comments

• tracing: Only prepare tracepoint arguments when actually tracing

  #26593 commented on Mar 23, 2024 • 0 new comments

• wallet: Migrate legacy wallets to descriptor wallets without requiring BDB

  #26596 commented on Mar 19, 2024 • 0 new comments

• rpc: parse legacy pubkeys consistently with specific error messages

  #28336 commented on Mar 20, 2024 • 0 new comments

• wallet: Construct ScriptPubKeyMans with all data rather than loaded progressively

  #28333 commented on Mar 19, 2024 • 0 new comments

• wallet: Implement independent BDB parser

  #26606 commented on Mar 19, 2024 • 0 new comments

• rpc, wallet: fix incorrect segwit redeem script size limit

  #28307 commented on Mar 19, 2024 • 0 new comments

• logging: use bitset for categories

  #26697 commented on Mar 22, 2024 • 0 new comments

• Silent payment index (for light wallets and consistency check)

  #28241 commented on Mar 17, 2024 • 0 new comments

• fuzz: wallet, add target for Spend

  #28236 commented on Mar 19, 2024 • 0 new comments

• fuzz: a new target for the coins database

  #28216 commented on Mar 23, 2024 • 0 new comments

• init: Add option for rpccookie permissions (replace 26088)

  #28167 commented on Mar 23, 2024 • 0 new comments

• Silent Payments: Implement BIP352

  #28122 commented on Mar 22, 2024 • 0 new comments

• security-check: test for `_FORTIFY_SOURCE` usage in release binaries

  #27038 commented on Mar 19, 2024 • 0 new comments

• wallet: Track no-longer-spendable TXOs separately

  #27865 commented on Mar 22, 2024 • 0 new comments

• validation: log which peer sent us a header

  #27826 commented on Mar 23, 2024 • 0 new comments

• wallet: add `seeds` argument to `importdescriptors`

  #27351 commented on Mar 20, 2024 • 0 new comments

• system: use %LOCALAPPDATA% as default datadir on windows

  #27064 commented on Mar 22, 2024 • 0 new comments

• Support JSON-RPC 2.0 when requested by client

  #27101 commented on Mar 22, 2024 • 0 new comments

• build: Bump clang minimum supported version to 15

  #29165 commented on Mar 19, 2024 • 0 new comments

• tests: add functional test for miniscript decaying multisig

  #29156 commented on Mar 19, 2024 • 0 new comments

• Bugfix: RPC: Check for blank rpcauth on a per-param basis

  #29141 commented on Mar 23, 2024 • 0 new comments

• wallet: `addhdkey` RPC to add just keys to wallets via new `void(KEY)` descriptor

  #29136 commented on Mar 20, 2024 • 0 new comments

• sync: introduce a thread-safe generic container and use it to remove a bunch of "GlobalMutex"es

  #25390 commented on Mar 23, 2024 • 0 new comments

• wallet, rpc: add BIP44 `account` in `createwallet`

  #29129 commented on Mar 19, 2024 • 0 new comments

• wallet: Automatically repair corrupted metadata with doubled derivation path

  #29124 commented on Mar 19, 2024 • 0 new comments

• guix: Use LTO to build releases

  #25391 commented on Mar 18, 2024 • 0 new comments

• [POC] guix: produce a fully `-static-pie` bitcoind

  #25573 commented on Mar 22, 2024 • 0 new comments

• [WIP, DO NOT MERGE!!11111!!!!!] build: Require libc++-16 or later

  #29077 commented on Mar 19, 2024 • 0 new comments

• refactor: Remove Span operator==, Use std::ranges::equal

  #29071 commented on Mar 22, 2024 • 0 new comments

• Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes

  #29050 commented on Mar 20, 2024 • 0 new comments

• versionbits refactoring

  #29039 commented on Mar 19, 2024 • 0 new comments

• wallet, rpc: add anti-fee-sniping to `send` and `sendall`

  #28944 commented on Mar 19, 2024 • 0 new comments

• refactor: Use util::Result class for wallet loading

  #25722 commented on Mar 23, 2024 • 0 new comments

• [refactor] Remove BlockAssembler m_mempool member

  #28843 commented on Mar 20, 2024 • 0 new comments

• tracing: network connection tracepoints

  #25832 commented on Mar 23, 2024 • 0 new comments

• ArgsManager: support subcommand-specific options

  #28802 commented on Mar 19, 2024 • 0 new comments

• Embedding ASMap files as binary dump header file

  #28792 commented on Mar 23, 2024 • 0 new comments

• Wallet: Functions to enable adding used balance to GUI overview page

  #28776 commented on Mar 19, 2024 • 0 new comments

• wallet: Cleanup accidental encryption keys in watchonly wallets

  #28724 commented on Mar 19, 2024 • 0 new comments

• [WIP] wallet: standardize change output detection process

  #25979 commented on Mar 20, 2024 • 0 new comments

• Add util::ResultPtr class

  #26022 commented on Mar 23, 2024 • 0 new comments

• net: Make AddrFetch connections to fixed seeds

  #26114 commented on Mar 23, 2024 • 0 new comments