Create Task
Maniphest T111894

MobileFrontend VisualEditor edit conflict detection does not work
Closed, ResolvedPublic8 Story Points
Actions

Description

Noticed while testing code for T110272

Krenair created this task.Sep 9 2015, 3:09 AM
Krenair added projects: MobileFrontend, Editing-Department.
Krenair added a subscriber: Krenair.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2015, 3:09 AM
Krenair added a comment.Sep 9 2015, 4:05 AM

I tested this a few different times locally and on beta, with VE editing and source editing. And usually it half worked. :/

Krenair added a comment.Sep 10 2015, 10:40 PM
Observed MobileFrontend edit conflict behaviourlocalhostbeta
WikitextError shown as text at bottom of screenError shown as text at bottom of screen
VisualEditorAPI returns conflict, no UI error, stuckNo error shown, overwrites?
Krenair changed the title from "MobileFrontend edit conflict detection does not work" to "MobileFrontend VisualEditor edit conflict detection does not work".Sep 10 2015, 10:41 PM
Krenair edited projects, added VisualEditor-MediaWiki; removed Editing-Department.
Krenair set Security to None.
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 10 2015, 10:41 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Sep 11 2015, 11:14 PM
Jdforrester-WMF edited a custom field.
gerritbot added a subscriber: gerritbot.Sep 25 2015, 11:02 PM

Change 241249 had a related patch set uploaded (by Alex Monk):
Save dialog: Make review/resolve actions work in mobile

https://gerrit.wikimedia.org/r/241249

Krenair claimed this task.Sep 25 2015, 11:04 PM
gerritbot added a comment.Sep 26 2015, 11:40 AM

Change 241250 merged by jenkins-bot:
Don't try to redirect to Special:MobileEditor on a POST request

https://gerrit.wikimedia.org/r/241250

gerritbot added a comment.Sep 26 2015, 11:42 AM

Change 241249 merged by jenkins-bot:
Save dialog: Make review/resolve actions work in mobile

https://gerrit.wikimedia.org/r/241249

Krenair added a comment.Sep 26 2015, 1:19 PM
Observed VisualEditor edit conflict behaviourlocalhostbeta
DesktopNo error returned, overwritesNo error returned, overwrites
MobileErrors correctlyNo error returned, overwrites
Krenair added a comment.Sep 26 2015, 1:33 PM

Turns out that's probably due to being the last user to edit the page logged in, causing the conflict to be suppressed by EditPage.

Add Comment

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use and Privacy Policy. · Wikimedia Foundation · Privacy Policy · Terms of Use · Disclaimer · CC-BY-SA · GPL