Opened 5 months ago
Last modified 4 days ago
#25663 new task (blessed)
Upgrade Plupload to 2.0
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | External Libraries | Keywords: | needs-testing has-patch |
Focuses: | Cc: |
Description
Plupload 2.0 was released about a month ago. Has quite a bit of fixes and improvements. The upgrade should be a straight replacement.
Attachments (3)
Change History (14)
comment:3
ocean90
— 4 months ago
- Keywords needs-patch early added
- Milestone changed from 3.8 to Future Release
Since the current uploader isn't much broken we can punt this for now.
Just an info: These are the files of 2.0.0:
moxie.js
moxie.min.js
Moxie.swf
Moxie.xap
plupload.dev.js
plupload.full.min.js
plupload.min.js
license.txt
And these are the current ones from core:
changelog.txt
license.txt
plupload.flash.js
plupload.flash.swf
plupload.html4.js
plupload.html5.js
plupload.js
plupload.silverlight.js
plupload.silverlight.xap
comment:4
azaozz
— 8 weeks ago
- Keywords needs-testing added; needs-patch early removed
- Milestone changed from Future Release to 3.9
In 25663.patch:
- Plupload 2.1.1.
- Remove support for Silverlight. Flash is used in IE < 10. If flash is not installed, it will fall back to html4.
- Remove the limitation and warnings for the flash runtime when uploading files larger than 100MB. Works well now.
comment:5
kovshenin
— 3 weeks ago
- Keywords has-patch added
Refreshed in 25663.diff, added Silverlight back together with Moxie.xap. The patch contains binary files as well as file deletions, should apply cleanly with svn patch path/to/file.diff.
Tested the html5, flash and html4 runtimes in Chrome on OS X, looks good. The flash runtime doesn't work in Safari and Firefox, still trying to debug why. Haven't tested Windows, IE or the silverlight runtime yet. Any help appreciated.
comment:8
TobiasBg
— 2 weeks ago
The moxie.xap has svn:executable set, so that file rights change from 644 to 755.
Not sure if this is necessary? Could that maybe cause problems with automatic updates?
comment:10
nacin
— 13 days ago
- Type changed from enhancement to task (blessed)
comment:11
kovshenin
— 4 days ago
Looked deeper into the Flash runtime issue in Firefox, Safari. It looks like Moxie.swf doesn't pass any cookies to async-upload.php so that's responding with a redirect. It works fine in Chrome and IE.
Been digging around the Plupload/Moxie forums and repo, but couldn't find much related. Closest I got was this 4yr old issue, where a suggested workaround was to include the session hash in the request. But then again everything worked well in 1.5.7 so I'm guessing it's a bug upstream with the change to Moxie.swf.
To work around this we can partially revert r18674 where we stopped passing our authentication cookies to post_params. The checks for them are still in place in async-upload.php, but need a small tweak to support the upload-attachment action (background: r22902).
Patch in 25663.2.diff.
Consider removing the Silverlight component. It is useful only for IE < 10 when there's no flash, which seems quite rare.